Fix Vert.x event bus codec registration #29446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `EventBusCodecProcessor` used to create a map from Jandex `Type` of message to a `DotName` of the corresponding codec, and then expose that map as a repeatable `MessageCodecBuildItem`. When creating each build item, the code used to call `Type.toString()`, which is never the right thing to do when obtaining a class name from Jandex `Type`. With this commit, the map is from type `DotName` to codec `DotName`, and the key in the map is obtained by `Type.name()`.
cescoffier
approved these changes
Nov 23, 2022
extensions/vertx/deployment/src/test/java/io/quarkus/vertx/EventBusCodecTest.java
Show resolved
Hide resolved
mkouba
approved these changes
Nov 23, 2022
mkouba
added
the
triage/waiting-for-ci
Failing Jobs - Building bba49af
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/opentelemetry-reactive-messaging integration-tests/reactive-messaging-hibernate-orm
📦 integration-tests/opentelemetry-reactive-messaging✖ 📦 integration-tests/reactive-messaging-hibernate-orm✖ ⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/reactive-messaging-hibernate-orm
📦 integration-tests/reactive-messaging-hibernate-orm✖ |
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
|
Any chance or plan to get it in 2.13 as well? From 2.14 we got many breaking changes thanks to kubernetes-client update, which is why I cannot update atm. |
Yes, this fix should land in the next 2.13 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EventBusCodecProcessorused to create a map from JandexTypeof message to aDotNameof the corresponding codec, and then expose that map as a repeatableMessageCodecBuildItem. When creating each build item, the code used to callType.toString(), which is never the right thing to do when obtaining a class name from JandexType.With this commit, the map is from type
DotNameto codecDotName, and the key in the map is obtained byType.name().Fixes #29434